Skip to content

Removing grpc_init() from places where it is no longer needed #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
csvance merged 1 commit into from
Feb 23, 2026
Merged

Removing grpc_init() from places where it is no longer needed #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,7 @@ include("gen/test/test_pb.jl")

@testset "gRPCClient.jl" begin

# Initialize the global gRPCCURL structure
grpc_init()

@testset "Code Generation" begin
grpc_register_service_codegen()
mktempdir() do tmpdir
@test isnothing(protojl("proto/test.proto", @__DIR__, tmpdir))
generated = read(joinpath(tmpdir, "test", "test_pb.jl"), String)
Expand Down
2 changes: 0 additions & 2 deletions utils/gRPCClientUtils.jl/src/Benchmark.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@ function perform_benchmark(f)
end

function benchmark_table()
grpc_init()

column_labels = [
[
"Benchmark",
Expand Down
2 changes: 0 additions & 2 deletions utils/gRPCClientUtils.jl/src/Profile.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
function profile_memory_fn(f::Function)
grpc_init()

# Warmup
_ = f()

Expand Down