Skip to content

Conversation

@xgdgsc
Copy link
Contributor

@xgdgsc xgdgsc commented Jan 2, 2026

fix #89

@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.30%. Comparing base (ad3fd46) to head (3229432).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
- Coverage   83.91%   83.30%   -0.62%     
==========================================
  Files           7        7              
  Lines         541      557      +16     
==========================================
+ Hits          454      464      +10     
- Misses         87       93       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@csvance
Copy link
Collaborator

csvance commented Jan 2, 2026

Looks good! It's neat how Julia lets you reference previous args, makes this pattern very clean to implement.

At some point we should update the docs to mention the new kwargs, but I'm fine doing that in a second round later. Better to get the master branch more usable for the actual users now. The documentation still builds fine, probably because the new arguments are kwargs with the same dispatch signature.

@csvance csvance self-requested a review January 2, 2026 14:54
@csvance csvance merged commit 8176e94 into JuliaIO:main Jan 2, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

current deadline setting breaks streaming

3 participants