Tear down GLMakie figures properly during precompilation#182
Merged
JamesWrigley merged 1 commit intomasterfrom Oct 15, 2025
Merged
Tear down GLMakie figures properly during precompilation#182JamesWrigley merged 1 commit intomasterfrom
JamesWrigley merged 1 commit intomasterfrom
Conversation
Calling `destroy_context()` after the renderloop is bad because the renderloop will clean up the ImGui resources (including the OpenGL context) when it finishes.
JamesWrigley
force-pushed
the
makie-precompilation
branch
from
0e08292 to
ec9618e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
destroy_context()after the renderloop is bad because the renderloop will clean up the ImGui resources (including the OpenGL context) when it finishes.Fixes #181.