Skip to content

unwrap rawview(::channelview) with one reshape reinterpret #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

unwrap rawview(::channelview) with one reshape reinterpret #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/ImageCore.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,11 @@ rawview(a::AbstractArray{T}) where {T<:FixedPoint} = mappedarray(reinterpret, y-
rawview(a::Array{T}) where {T<:FixedPoint} = reinterpret(FixedPointNumbers.rawtype(T), a)
rawview(a::AbstractArray{T}) where {T<:Real} = a

if VERSION >= v"1.6.0-DEV.1083"
# does not use the slow `mappedarray` fallback for, typically, `rawview(channelview(img))`
rawview(a::Base.ReinterpretArray{T}) where {T<:FixedPoint} = reinterpret(reshape, FixedPointNumbers.rawtype(T), parent(a))
end

"""
normedview([T], img::AbstractArray{Unsigned})

Expand Down
7 changes: 5 additions & 2 deletions test/show.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,11 @@ RGB_str = typestring(RGB)
rgb8 = rand(RGB{N0f8}, 3, 5)
c = rawview(channelview(rgb8))
str = summary(c)
@test occursin("3×3×5 rawview(reinterpret($(rrstr)", str) && occursin("N0f8", str) &&
occursin("::Array{RGB{N0f8},$(rrdim(3))}", str) && occursin("with eltype UInt8", str)
if VERSION >= v"1.6.0-DEV.1083"
@test str == "3×3×5 reinterpret(reshape, UInt8, ::Array{RGB{N0f8},2}) with eltype UInt8"
else
@test str == "3×3×5 rawview(reinterpret(N0f8, ::Array{RGB{N0f8},3})) with eltype UInt8"
end
@test summary(rgb8) == "3×5 Array{RGB{N0f8},2} with eltype $(RGB_str){$(N0f8_str)}"
rand8 = rand(UInt8, 3, 5)
d = normedview(PermutedDimsArray(rand8, (2,1)))
Expand Down
13 changes: 13 additions & 0 deletions test/views.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,19 @@ using PaddedViews: filltype
v[2,2] = 0x0f
@test a[2,2].i == 0x0f
@test rawview(v) === v

if VERSION >= v"1.6.0-DEV.1083"
@testset "rawview(::AbstractArray)" begin
a = rand(RGB{N0f8}, 5, 5)
X1 = rawview(channelview(a))
X2 = rawview(collect(channelview(a)))
@test !isa(parent(X1), Base.ReinterpretArray)
@test typeof(X1) != typeof(X2)
@test axes(X1) == axes(X2)
@test eltype(X1) == eltype(X2)
@test X1 == X2
end
end
end

@testset "normedview" begin
Expand Down