Skip to content

Conversation

johnnychen94
Copy link
Member

@johnnychen94 johnnychen94 commented May 19, 2021

Here's my plan for the next minor release:

Todo:

bugs:

maintenance:

enhancements:


The test failure is due to version locks on test dependency, no need to worry about.

@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #122 (71efff6) into master (e1ef518) will decrease coverage by 2.03%.
The diff coverage is 50.00%.

❗ Current head 71efff6 differs from pull request most recent head bdd857a. Consider uploading reports for the commit bdd857a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
- Coverage   91.09%   89.06%   -2.04%     
==========================================
  Files           8        8              
  Lines         191      192       +1     
==========================================
- Hits          174      171       -3     
- Misses         17       21       +4     
Impacted Files Coverage Δ
src/ImageTransformations.jl 83.33% <ø> (ø)
src/compat.jl 16.66% <20.00%> (-63.34%) ⬇️
src/autorange.jl 92.68% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1ef518...bdd857a. Read the comment docs.

@johnnychen94
Copy link
Member Author

johnnychen94 commented Aug 19, 2021

Interesting... The test dependency ReferenceTests v0.9.8 actually isn't compatible with ImageTransformations v0.9 yet the test still runs without an error.

@timholy #142 has become quite delicate so I don't plan to ship it in this release. That said I'm okay to merge this and tag a new release.

Copy link
Member

@timholy timholy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome! You've done absolutely heroic work here. Merge at will.

CHANGELOG.md Outdated
- ![Enhancement][badge-enhancement] `restrict` now works on 0-argument colorant types(e.g., `ARGB32`). ([ImageBase#3][github-base-3])
- ![Bugfix][badge-bugfix] Interpolations v0.13.3 compatibility. ([#132][github-132])
- ![Bugfix][badge-bugfix] `restrict` on singleton dimension is now a no-op. ([ImageBase#8][github-base-8])
- ![Bugfix][badge-bugfix] `restrict` on `OffsetArray` is now type stable. ([ImageBase#4][github-base-4])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- ![Bugfix][badge-bugfix] `restrict` on `OffsetArray` is now type stable. ([ImageBase#4][github-base-4])
- ![Bugfix][badge-bugfix] `restrict` on `OffsetArray` always returns an `OffsetArray` result. ([ImageBase#4][github-base-4])

The meaning of "type-stable" is a little bit ambiguous: sometimes it means "the same type," but more often it simply means inferrable. Because of the potential for confusion, I think it's best to be specific.

Copy link
Member Author

@johnnychen94 johnnychen94 Aug 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I did mean inferrable here (#118) but it's almost the same 😄

@johnnychen94 johnnychen94 marked this pull request as ready for review August 19, 2021 10:14
@johnnychen94 johnnychen94 merged commit 4d89e5c into master Aug 19, 2021
@johnnychen94 johnnychen94 deleted the jc/09 branch August 19, 2021 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants