Require Julia 1.10 and deprecate type-pirating methods #837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am really in favor of getting rid of the type piracy like your are doing here. One minor comment: In the feature overview at https://github.com/JuliaLang/Compat.jl/tree/mh/deprecate-type-piracy?tab=readme-ov-file#supported-features, it looks a bit weird that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compat dropped support for Julia versions prior to v1.6 about 14 months after it was released, 6 months after it became LTS (by the release of 1.7). As v1.10 has been released about 13 months ago and became LTS about 5 months ago, we can start thinking about dropping support for versions prior to v1.10. Which this PR does.
Seizing the opportunity of a major version bump, this does another change that might be worth more discussion: It resolves #814 by applying it to the few remaining offenders. Maybe this PR - threatening to actually have an impact - receives more feedback than #814... If there are objections, I happily remove the last two commits to reduce this to the minimum-required-version-bump only.