Skip to content

SSHManager: Add the custom_worker_flag option, but don't add it to the public API #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

SSHManager: Add the custom_worker_flag option, but don't add it to the public API #135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/managers.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,7 @@
:sshflags => ``,
:shell => :posix,
:cmdline_cookie => false,
:custom_worker_flag => nothing,
:env => [],
:tunnel => false,
:multiplex => false,
Expand Down Expand Up @@ -238,6 +239,7 @@
tunnel = params[:tunnel]
multiplex = params[:multiplex]
cmdline_cookie = params[:cmdline_cookie]
custom_worker_flag = params[:custom_worker_flag]

Check warning on line 242 in src/managers.jl

View check run for this annotation

Codecov / codecov/patch

src/managers.jl#L242 

Added line #L242 was not covered by tests
env = Dict{String,String}(params[:env])

# machine could be of the format [user@]host[:port] bind_addr[:bind_port]
Expand All @@ -249,10 +251,14 @@
if length(machine_bind) > 1
exeflags = `--bind-to $(machine_bind[2]) $exeflags`
end
if cmdline_cookie
exeflags = `$exeflags --worker=$(cluster_cookie())`
if isnothing(custom_worker_flag)
if cmdline_cookie
exeflags = `$exeflags --worker=$(cluster_cookie())`

Check warning on line 256 in src/managers.jl

View check run for this annotation

Codecov / codecov/patch

src/managers.jl#L254-L256 

Added lines #L254 - L256 were not covered by tests
else
exeflags = `$exeflags --worker`

Check warning on line 258 in src/managers.jl

View check run for this annotation

Codecov / codecov/patch

src/managers.jl#L258 

Added line #L258 was not covered by tests
end
else
exeflags = `$exeflags --worker`
exeflags = `$exeflags $custom_worker_flag`

Check warning on line 261 in src/managers.jl

View check run for this annotation

Codecov / codecov/patch

src/managers.jl#L261 

Added line #L261 was not covered by tests
end

host, portnum = parse_machine(machine_bind[1])
Expand Down
Loading