Fix JET errors around matching methods for run_work_thunk(...)#168
Closed
DilumAluthge wants to merge 4 commits intomasterfrom
Closed
Fix JET errors around matching methods for run_work_thunk(...)#168DilumAluthge wants to merge 4 commits intomasterfrom
run_work_thunk(...)#168DilumAluthge wants to merge 4 commits intomasterfrom
Conversation
``` │┌ run_work_thunk(rv::Distributed.RemoteValue, thunk::Bool) @ Distributed /workpath/Distributed.jl/src/process_messages.jl:79 ││ no matching method found `run_work_thunk(::Bool, ::Bool)`: Distributed.run_work_thunk(thunk::Bool, false) │└──────────────────── ``` (cherry picked from commit 402d38b)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #168 +/- ##
=======================================
Coverage 79.45% 79.45%
=======================================
Files 10 10
Lines 1957 1957
=======================================
Hits 1555 1555
Misses 402 402 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
src/process_messages.jl
Outdated
| return result | ||
| end | ||
| function run_work_thunk(rv::RemoteValue, thunk) | ||
| function run_work_thunk(rv::RemoteValue, thunk::Function) |
Member
There was a problem hiding this comment.
I'm not sure about this because theoretically I think this could receive a callable struct as well. Would Base.Callable work?
Member
Author
There was a problem hiding this comment.
Good point. I think Base.Callable should still work, since it still excludes Bool.
Member
Author
Member
Author
|
Hmmm. I want to think about this a bit more. |
Member
Author
|
I think #181 might be better. |
Member
Author
|
Closing in favor of #181 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.