Skip to content

Conversation

@lbilli
Copy link

@lbilli lbilli commented Feb 7, 2021

What about adding compression by default?

The empty string "" instructs libcurl to add an Accept-Encoding: header containing all built-in supported encodings.

@codecov-io
Copy link

codecov-io commented Feb 7, 2021

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.96%. Comparing base (88a217c) to head (a1461f9).
⚠️ Report is 99 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
+ Coverage   92.94%   92.96%   +0.01%     
==========================================
  Files           5        5              
  Lines         482      483       +1     
==========================================
+ Hits          448      449       +1     
  Misses         34       34              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@StefanKarpinski
Copy link
Member

StefanKarpinski commented Mar 23, 2021

It seems that setting this option not only affects what libcurl advertises as accepting but has the side effect of actually doing the decoding before the data is passed to the caller. That might be good but it's certainly worth considering whether we want to do that. It may also be a breaking change since callers that are setting the Accept-Encoding header already and expecting encoded data will no longer get encoded data.

@tecosaur
Copy link
Member

What if we just checked the headers passed, and only set this to do "automatic decompression" when there is no explicit Accept-Encoding header?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants