Skip to content

Performance debugging: make graph.attributes a Dict #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 21, 2025
Merged

Performance debugging: make graph.attributes a Dict #12

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
285b695
Make `graph.attributes` a Dict
mlechu Apr 28, 2025
dde4ac4
Allow `SyntaxGraph{<:NamedTuple}`, but don't use it for now
mlechu Apr 30, 2025
11b3733
Mark `SyntaxGraph` and `SyntaxList` mutable instead
mlechu May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/syntax_graph.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ one or several syntax trees.

TODO: Global attributes!
"""
struct SyntaxGraph{Attrs}
mutable struct SyntaxGraph{Attrs}
edge_ranges::Vector{UnitRange{Int}}
edges::Vector{NodeId}
attributes::Attrs
Expand Down Expand Up @@ -632,7 +632,7 @@ end

#-------------------------------------------------------------------------------
# Lightweight vector of nodes ids with associated pointer to graph stored separately.
struct SyntaxList{GraphType, NodeIdVecType} <: AbstractVector{SyntaxTree}
mutable struct SyntaxList{GraphType, NodeIdVecType} <: AbstractVector{SyntaxTree}
graph::GraphType
ids::NodeIdVecType
end
Expand Down