Skip to content

build_tree: clarify accepted keyword arguments #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2025
Merged

build_tree: clarify accepted keyword arguments #571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/integration/expr.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,7 +609,10 @@ end
return retexpr
end

function build_tree(::Type{Expr}, stream::ParseStream; filename=nothing, first_line=1, kws...)
function build_tree(::Type{Expr}, stream::ParseStream;
filename=nothing, first_line=1,
# unused, but required since `_parse` is written generic
keep_parens=false)
source = SourceFile(stream, filename=filename, first_line=first_line)
return build_tree(Expr, stream, source)
end
Expand Down
4 changes: 3 additions & 1 deletion src/porcelain/green_node.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,9 @@ function GreenNode(cursor::GreenTreeCursor)
end
end

function build_tree(T::Type{GreenNode}, stream::ParseStream; kws...)
function build_tree(::Type{GreenNode}, stream::ParseStream;
# unused, but required since `_parse` is written generic
filename=nothing, first_line=1, keep_parens=false)
cursor = GreenTreeCursor(stream)
if has_toplevel_siblings(cursor)
# There are multiple toplevel nodes, e.g. because we're using this
Expand Down
2 changes: 1 addition & 1 deletion src/porcelain/syntax_tree.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ end
Base.copy(data::SyntaxData) = SyntaxData(data.source, data.raw, data.byte_end, data.val)

function build_tree(::Type{SyntaxNode}, stream::ParseStream;
filename=nothing, first_line=1, keep_parens=false, kws...)
filename=nothing, first_line=1, keep_parens=false)
source = SourceFile(stream, filename=filename, first_line=first_line)
cursor = RedTreeCursor(stream)
if has_toplevel_siblings(cursor)
Expand Down
Loading