Skip to content

_register_kinds!: prevent unintentional closure capture, boxing #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 26, 2025
Merged

_register_kinds!: prevent unintentional closure capture, boxing #586

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f8266b
`_register_kinds!`: prevent unintentional closure capture, boxing
nsajko Aug 25, 2025
0b85833
add comment on the motivation as suggested by aviatesk
nsajko Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/julia/kinds.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,10 @@ function _register_kinds!(kind_modules, int_to_kindstr, kind_str_to_int, mod, mo
error("Kind module ID $module_id already claimed by module $m")
end
end
_register_kinds_names!(int_to_kindstr, kind_str_to_int, module_id, names)
end

function _register_kinds_names!(int_to_kindstr, kind_str_to_int, module_id, names)
# Process names to conflate category BEGIN/END markers with the first/last
# in the category.
i = 0
Expand Down
Loading