Skip to content

Conversation

@mlechu
Copy link
Member

@mlechu mlechu commented Sep 29, 2025

Adapt to changes in macro name kinds. This is part of the effort to get everything on the same JuliaSyntax version so JuliaSyntax and JuliaLowering may be brought into the JuliaLang/julia source tree.

@mlechu mlechu marked this pull request as ready for review September 30, 2025 18:29
@mlechu
Copy link
Member Author

mlechu commented Sep 30, 2025

CI is a bit sleepy at the moment, but tests are underway at JuliaLang/julia#59565. @tecosaur Requesting your review whenever you get the chance; I don't have the permissions to add you as a reviewer.

@aviatesk
Copy link
Member

aviatesk commented Oct 8, 2025

@tecosaur Apologize for the interruption, but could I ask for an update on this?. We're working on porting JuliaSyntax (and JuliaLowering) to Base, but our progress is currently blocked by this PR.

@mlechu mlechu merged commit 14d4d09 into JuliaLang:main Oct 14, 2025
0 of 4 checks passed
@KristofferC
Copy link
Member

How do I use this package now?

ERROR: The following 1 direct dependency failed to precompile:

JuliaSyntaxHighlighting 

Failed to precompile JuliaSyntaxHighlighting [ac6e5ff7-fb65-4e79-a425-ec3bc9c03011] to "/Users/kc/.julia/compiled/v1.13/JuliaSyntaxHighlighting/jl_MSs4NO" (ProcessExited(1)).
ERROR: LoadError: unknown Kind name "macro_name"

@mlechu
Copy link
Member Author

mlechu commented Oct 14, 2025

After JuliaLang/julia#59565 is merged, JuliaSyntaxHighlighting's use of Base.JuliaSyntax will work again. Let me know if there's a better way of doing this sort of update, though, because I agree this isn't ideal.

@KristofferC
Copy link
Member

After JuliaLang/julia#59565 is merged, JuliaSyntaxHighlighting's use of Base.JuliaSyntax will work again.

Thanks! Works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants