Add 'eigmin'/'eigmax' methods for 'Eigen' #1468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luis-Varona
force-pushed
the
1464-Eigen-methods
branch
from
6d23c53 to
b80df40
Compare
We add the methods 'eigmin' and 'eigmax' on the type 'F::Union{Eigen, GeneralizedEigen}' similarly to how 'eigvals' is defined on 'F'. Note that the corresponding unit tests in 'test/eigen.jl' that call 'eigvals' on such a struct are updated to include 'eigmin' and 'eigmax' calls as well; if all eigenvalues are real, the actual functionality of the methods is tested, and if any happen to be complex, then we test that they throw 'MethodError's.
(Resolves JuliaLang#1464 by @longemen3000.)
Luis-Varona
force-pushed
the
1464-Eigen-methods
branch
from
b80df40 to
ff77b71
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1468 +/- ##
=======================================
Coverage 93.89% 93.89%
=======================================
Files 34 34
Lines 15926 15926
=======================================
+ Hits 14953 14954 +1
+ Misses 973 972 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jishnub
approved these changes
Oct 9, 2025
This commit incorporates changes suggested by @jishnub to edit all associated 'F.values'/'f.values' calls in the diff to 'eigvals(F)'/'eigvals(f)' instead. Co-authored-by: Jishnu Bhattacharya <[email protected]>
|
@jishnub, I've made the requested changes. Thanks for the review. |
|
Hi @jishnub - do you think this is all ready to be merged now? :) |
jishnub
approved these changes
Oct 12, 2025
|
Thanks! |
|
Should these functions be doced? |
I was wondering that too, but the already existing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add the methods 'eigmin' and 'eigmax' on the type 'F::Union{Eigen, GeneralizedEigen}' similarly to how 'eigvals' is defined on 'F'. Note that the corresponding unit tests in 'test/eigen.jl' that call 'eigvals' on such a struct are updated to include 'eigmin' and 'eigmax' calls as well; if all eigenvalues are real, the actual functionality of the methods is tested, and if any happen to be complex, then we test that they throw 'MethodError's.
(Resolves #1464 by @longemen3000.)