Skip to content

Add 'eigmin'/'eigmax' methods for 'Eigen' #1468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 12, 2025
Merged

Add 'eigmin'/'eigmax' methods for 'Eigen' #1468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff77b71
Add 'eigmin'/'eigmax' methods for 'Eigen'
Luis-Varona Oct 9, 2025
fe5a63b
Change 'F.values' calls to 'eigvals(F)'
Luis-Varona Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/eigen.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,8 @@ eigvecs(A::Union{Number, AbstractMatrix}; kws...) =
eigvecs(F::Union{Eigen, GeneralizedEigen}) = F.vectors

eigvals(F::Union{Eigen, GeneralizedEigen}) = F.values
eigmin(F::Union{Eigen, GeneralizedEigen}) = minimum(eigvals(F))
eigmax(F::Union{Eigen, GeneralizedEigen}) = maximum(eigvals(F))

"""
eigvals!(A; permute::Bool=true, scale::Bool=true, sortby) -> values
Expand Down
18 changes: 18 additions & 0 deletions test/eigen.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,15 @@ aimg = randn(n,n)/2
@test inv(a) ≈ inv(f)
@test isposdef(a) == isposdef(f)
@test eigvals(f) === f.values

if all(isreal, eigvals(f))
@test eigmin(f) == minimum(eigvals(f))
@test eigmax(f) == maximum(eigvals(f))
else
@test_throws MethodError eigmin(f)
@test_throws MethodError eigmax(f)
end

@test eigvecs(f) === f.vectors
@test Array(f) ≈ a

Expand Down Expand Up @@ -81,6 +90,15 @@ aimg = randn(n,n)/2
@test prod(f.values) ≈ prod(eigvals(asym_sg/(ASG2))) atol=200ε
@test eigvecs(asym_sg, ASG2) == f.vectors
@test eigvals(f) === f.values

if all(isreal, eigvals(f))
@test eigmin(f) == minimum(eigvals(f))
@test eigmax(f) == maximum(eigvals(f))
else
@test_throws MethodError eigmin(f)
@test_throws MethodError eigmax(f)
end

@test eigvecs(f) === f.vectors
@test_throws FieldError f.Z

Expand Down