Skip to content

faster implementation of rank(::QRPivoted) fixes #1128 #1129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 2, 2024
Merged

faster implementation of rank(::QRPivoted) fixes #1128 #1129

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9cf5df3
added rank method for SVD object alongwith unit tests for the method.…
ajinkya-k Nov 29, 2024
7764601
faster implementation of rank(::QRPivoted)
ajinkya-k Nov 29, 2024
d7942fb
added stevengj's suggestion to qr. reversed changes in svd
ajinkya-k Nov 29, 2024
d270bda
minor edit to qr(::QRPivoted)
ajinkya-k Nov 30, 2024
c4aa5f3
simplified rank(::QRPivoted) implementation
ajinkya-k Dec 1, 2024
d1c35e6
simplified the rtol default eps call in rank(::QRPivoted)
ajinkya-k Dec 1, 2024
3ee69e6
using eltype(A) instead of eltype(A.Q) in the default val for rtol in…
ajinkya-k Dec 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/qr.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,8 +538,10 @@ end
function rank(A::QRPivoted; atol::Real=0, rtol::Real=min(size(A)...) * eps(real(float(one(eltype(A.Q))))) * iszero(atol))
m = min(size(A)...)
m == 0 && return 0
tol = max(atol, rtol*abs(A.R[1,1]))
return something(findfirst(i -> abs(A.R[i,i]) <= tol, 1:m), m+1) - 1
factors = getfield(A, :factors)
tol = max(atol, rtol*abs(factors[1,1]))

return something(findfirst(i -> abs(factors[i,i]) <= tol, 1:m), m+1) - 1
end

# Julia implementation similar to xgelsy
Expand Down