Skip to content

Special case Bool alpha in muldiag #1216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Special case Bool alpha in muldiag #1216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/diagonal.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,6 +382,14 @@ end
end
return out
end
@inline function __muldiag_nonzeroalpha!(out, D::Diagonal, B, alpha::Bool, beta::Number)
@inbounds for j in axes(B, 2)
@simd for i in axes(B, 1)
@stable_muladdmul _modify!(MulAddMul(true,beta), D.diag[i] * B[i,j], out, (i,j))
end
end
return out
end
_has_matching_zeros(out::UpperOrUnitUpperTriangular, A::UpperOrUnitUpperTriangular) = true
_has_matching_zeros(out::LowerOrUnitLowerTriangular, A::LowerOrUnitLowerTriangular) = true
_has_matching_zeros(out, A) = false
Expand Down Expand Up @@ -429,6 +437,15 @@ end
end
return out
end
@inline function __muldiag_nonzeroalpha_right!(out, A, D::Diagonal, alpha::Bool, beta::Number)
@inbounds for j in axes(A, 2)
dja = @stable_muladdmul MulAddMul(true,false)(D.diag[j])
@simd for i in axes(A, 1)
@stable_muladdmul _modify!(MulAddMul(true,beta), A[i,j] * dja, out, (i,j))
end
end
return out
end

function __muldiag_nonzeroalpha!(out, A, D::Diagonal, alpha::Number, beta::Number)
__muldiag_nonzeroalpha_right!(out, A, D, alpha, beta)
Expand Down