Skip to content

Avoid accessing unset indices in symmetric copyto! #1244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025
Merged

Avoid accessing unset indices in symmetric copyto! #1244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/symmetric.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ function copyto!(dest::Symmetric, src::Symmetric)
elseif src.uplo == dest.uplo
copytrito!(dest.data, src.data, src.uplo)
else
transpose!(dest.data, Base.unalias(dest.data, src.data))
copytrito!(dest.data, transpose(Base.unalias(dest.data, src.data)), dest.uplo)
end
return dest
end
Expand All @@ -363,7 +363,7 @@ function copyto!(dest::Hermitian, src::Hermitian)
elseif src.uplo == dest.uplo
copytrito!(dest.data, src.data, src.uplo)
else
adjoint!(dest.data, Base.unalias(dest.data, src.data))
copytrito!(dest.data, adjoint(Base.unalias(dest.data, src.data)), dest.uplo)
end
return dest
end
Expand Down
15 changes: 15 additions & 0 deletions test/symmetric.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1163,4 +1163,19 @@ end
end
end

@testset "copyto! with mismatched uplo" begin
for (S,tf) in ((Symmetric, transpose), (Hermitian, adjoint))
for (uplo1,uplo2) in [(:U,:L), (:L, :U)]
M = Matrix{Complex{BigFloat}}(undef, 2, 2)
M[1,1] = M[2,2] = 3
isupper = uplo1 == :U
M[1+!isupper, 1+isupper] = 4+3im
H1 = S(M, uplo1)
H2 = 2 * S(tf(M), uplo2)
copyto!(H2, H1)
@test H2 == H1
end
end
end

end # module TestSymmetric