Test for versioninfo with ENV variable
#1279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1279 +/- ##
=======================================
Coverage 92.00% 92.00%
=======================================
Files 34 34
Lines 15488 15488
=======================================
Hits 14249 14249
Misses 1239 1239 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@fredrikekre @KristofferC Do the Julia tests run multi-threaded - which might cause this to be an issue once in a while? |
Member
Author
|
Gentle bump |
Member
|
I do believe these tests do not run multi-threaded. Let's merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly check that setting an environment variable updates the
versioninfo.One concern here is that
withenvisn't thread-safe, but we're probably not running these tests multi threaded? In any case, it's unlikely that setting the number of MKL threads will impact anything.