Fix lmul!/rmul! for 0-sized matrices
#1290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkarrasch
approved these changes
Apr 14, 2025
Member
dkarrasch
left a comment
dkarrasch
left a comment
There was a problem hiding this comment.
What follows could be set in @inbounds context, right?
jishnub
force-pushed
the
jishnub/lmul_zerosize
branch
from
2d2919d to
4aca274
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1290 +/- ##
=======================================
Coverage 92.03% 92.04%
=======================================
Files 34 34
Lines 15499 15501 +2
=======================================
+ Hits 14265 14268 +3
+ Misses 1234 1233 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes scaling
Bidiaognalmatrices byDiagonalones when they're both empty.