Skip to content

Test two combinations in triangular test sets #1294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 22, 2025
Merged

Test two combinations in triangular test sets #1294

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f68e856
Fix variable name in testtriag.jl loop
jishnub Apr 21, 2025
e3eacb6
Remove unintended dot
jishnub Apr 21, 2025
d8530d7
Select types randomly
jishnub Apr 21, 2025
63aeb4a
Revert "Select types randomly"
jishnub Apr 22, 2025
bd03267
Update condition as suggested
jishnub Apr 22, 2025
e883422
Change `elty2` and `eltyB` loop bounds
jishnub Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions test/testtriag.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,10 +314,10 @@ function test_triangular(elty1_types)
@test ((A1 \ A1)::t1) ≈ M1 \ M1

# Begin loop for second Triangular matrix
@testset for elty2 in (Float32, Float64, BigFloat, ComplexF32, ComplexF64, Complex{BigFloat}, Int)
@testset for elty2 in push!(Set((ComplexF32, Int)), elty1)
# Only test methods for the same element type and a single combination of mixed element types
# to avoid too much compilation
if !(elty1 == elty2 || elty1 ∈ (ComplexF32, Int) || elty1 ∈ (ComplexF32, Int))
if elty1 ∉ (elty2, ComplexF32, Int)
continue
end
@testset for (t2, uplo2) in ((UpperTriangular, :U),
Expand Down Expand Up @@ -409,10 +409,10 @@ function test_triangular(elty1_types)
end
end

@testset for eltyB in (Float32, Float64, BigFloat, ComplexF32, ComplexF64, Complex{BigFloat})
@testset for eltyB in push!(Set((ComplexF32,)), elty1)
# Only test methods for the same element type and a single combination of mixed element types
# to avoid too much compilation
if !(elty1 == eltyB || elty1 ∈ (ComplexF32, Int) || eltyB ∈ (ComplexF32, Int))
if elty1 ∉ (eltyB, ComplexF32, Int)
continue
end

Expand Down