Skip to content

Precise axes in generic_mattrimul! #1300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025
Merged

Precise axes in generic_mattrimul! #1300

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions src/triangular.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1391,7 +1391,7 @@ function generic_trimatmul!(C::AbstractVecOrMat, uploc, isunitc, tfun::Function,
@inbounds if uploc == 'U'
if tfun === identity
for j in axes(B,2)
for i in axes(B,1)
for i in axes(A,1)
Cij = (unit ? oA : A[i,i]) * B[i,j]
for k in i + 1:lastindex(B,1)
Cij += A[i,k] * B[k,j]
Expand All @@ -1413,7 +1413,7 @@ function generic_trimatmul!(C::AbstractVecOrMat, uploc, isunitc, tfun::Function,
else # uploc == 'L'
if tfun === identity
for j in axes(B,2)
for i in reverse(axes(B,1))
for i in reverse(axes(A,1))
Cij = (unit ? oA : A[i,i]) * B[i,j]
for k in firstindex(B,1):i - 1
Cij += A[i,k] * B[k,j]
Expand All @@ -1423,7 +1423,7 @@ function generic_trimatmul!(C::AbstractVecOrMat, uploc, isunitc, tfun::Function,
end
else # tfun in (transpose, adjoint)
for j in axes(B,2)
for i in axes(B,1)
for i in axes(A,2)
Cij = (unit ? oA : tfun(A[i,i])) * B[i,j]
for k in i + 1:lastindex(B,1)
Cij += tfun(A[k,i]) * B[k,j]
Expand All @@ -1444,7 +1444,7 @@ function generic_trimatmul!(C::AbstractVecOrMat, uploc, isunitc, ::Function, xA:
unit = isunitc == 'U'
@inbounds if uploc == 'U'
for j in axes(B,2)
for i in axes(B,1)
for i in axes(A,1)
Cij = (unit ? oA : conj(A[i,i])) * B[i,j]
for k in i + 1:lastindex(B,1)
Cij += conj(A[i,k]) * B[k,j]
Expand All @@ -1454,7 +1454,7 @@ function generic_trimatmul!(C::AbstractVecOrMat, uploc, isunitc, ::Function, xA:
end
else # uploc == 'L'
for j in axes(B,2)
for i in reverse(axes(B,1))
for i in reverse(axes(A,1))
Cij = (unit ? oA : conj(A[i,i])) * B[i,j]
for k in firstindex(B,1):i - 1
Cij += conj(A[i,k]) * B[k,j]
Expand All @@ -1474,7 +1474,7 @@ function generic_mattrimul!(C::AbstractMatrix, uploc, isunitc, tfun::Function, A
@inbounds if uploc == 'U'
if tfun === identity
for i in axes(A,1)
for j in reverse(axes(A,2))
for j in reverse(axes(B,2))
Cij = A[i,j] * (unit ? oB : B[j,j])
for k in firstindex(A,2):j - 1
Cij += A[i,k] * B[k,j]
Expand All @@ -1484,7 +1484,7 @@ function generic_mattrimul!(C::AbstractMatrix, uploc, isunitc, tfun::Function, A
end
else # tfun in (transpose, adjoint)
for i in axes(A,1)
for j in axes(A,2)
for j in axes(B,1)
Cij = A[i,j] * (unit ? oB : tfun(B[j,j]))
for k in j + 1:lastindex(A,2)
Cij += A[i,k] * tfun(B[j,k])
Expand All @@ -1496,7 +1496,7 @@ function generic_mattrimul!(C::AbstractMatrix, uploc, isunitc, tfun::Function, A
else # uploc == 'L'
if tfun === identity
for i in axes(A,1)
for j in axes(A,2)
for j in axes(B,2)
Cij = A[i,j] * (unit ? oB : B[j,j])
for k in j + 1:lastindex(A,2)
Cij += A[i,k] * B[k,j]
Expand All @@ -1506,7 +1506,7 @@ function generic_mattrimul!(C::AbstractMatrix, uploc, isunitc, tfun::Function, A
end
else # tfun in (transpose, adjoint)
for i in axes(A,1)
for j in reverse(axes(A,2))
for j in reverse(axes(B,1))
Cij = A[i,j] * (unit ? oB : tfun(B[j,j]))
for k in firstindex(A,2):j - 1
Cij += A[i,k] * tfun(B[j,k])
Expand All @@ -1527,7 +1527,7 @@ function generic_mattrimul!(C::AbstractMatrix, uploc, isunitc, ::Function, A::Ab
unit = isunitc == 'U'
@inbounds if uploc == 'U'
for i in axes(A,1)
for j in reverse(axes(A,2))
for j in reverse(axes(B,2))
Cij = A[i,j] * (unit ? oB : conj(B[j,j]))
for k in firstindex(A,2):j - 1
Cij += A[i,k] * conj(B[k,j])
Expand All @@ -1537,7 +1537,7 @@ function generic_mattrimul!(C::AbstractMatrix, uploc, isunitc, ::Function, A::Ab
end
else # uploc == 'L'
for i in axes(A,1)
for j in axes(A,2)
for j in axes(B,2)
Cij = A[i,j] * (unit ? oB : conj(B[j,j]))
for k in j + 1:lastindex(A,2)
Cij += A[i,k] * conj(B[k,j])
Expand Down