- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 35
 
Structured broadcasting for UpperHessenberg #1325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
          Codecov Report❌ Patch coverage is  
 Additional details and impacted files@@           Coverage Diff           @@
##           master    #1325   +/-   ##
=======================================
  Coverage   93.81%   93.81%           
=======================================
  Files          34       34           
  Lines       15717    15738   +21     
=======================================
+ Hits        14745    14765   +20     
- Misses        972      973    +1     ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
  | 
    
43b3963    to
    499c286      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome how "little" work needs to be done to make it work.
| 
               | 
          ||
| @testset "Rectangular UpperHessenberg" begin | ||
| UH = UpperHessenberg(ones(4,3)) | ||
| UH2 = UH .+ UH .- UH | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would that even work with
| UH2 = UH .+ UH .- UH | |
| UH2 = UH + UH - UH | 
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it would. Should I add a test to compare these?
b17c415    to
    8890486      
    Compare
  
    | 
           Ready to merge?  | 
    
| 
           Perhaps we may merge for now and iteratively improve this.  | 
    
This adds a custom structured broadcasting style for an
UpperHessenberg, which now retains structure on some broadcasting operations.Unlike an
UpperTriangular, anUpperHessenbergcan retain its structure in broadcasting operations involving other banded matrices such anTridiagonal. We may also, in the future, make::UpperTriangular .+ ::Bidiagonalproduce anUpperHessenberg.