Make fillband! public and specialize for banded matrices
#1345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1345 +/- ##
==========================================
+ Coverage 93.81% 93.84% +0.02%
==========================================
Files 34 34
Lines 15722 15812 +90
==========================================
+ Hits 14750 14839 +89
- Misses 972 973 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This looks good and straightforward, and perhaps good to rebase and merge (before getting conflicts again). |
jishnub
force-pushed
the
jishnub/fillband
branch
from
1115743 to
7811cbf
Compare
jishnub
force-pushed
the
jishnub/fillband
branch
from
e35ea65 to
1b69850
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In parallel with
fillstored!, this allows one to fill a structured matrix. In addition, this is a useful function in structured matrix multiplication operations where only certain bands need to be populated. It would be good to have this public, so that sparse matrix types may add methods.