Skip to content

Conversation

@jishnub
Copy link
Member

@jishnub jishnub commented May 12, 2025

After this, scaling unit triangular matrices with parents that don't have the diagonal initialized works.

julia> M = Matrix{BigFloat}(undef,2,2);
  
julia> M[1,2] = 3;

julia> U = UnitUpperTriangular(M)
2×2 UnitUpperTriangular{BigFloat, Matrix{BigFloat}}:
 1.0  3.0
     1.0

julia> U * 2
2×2 UpperTriangular{BigFloat, Matrix{BigFloat}}:
 2.0  6.0
     2.0

Probably needs #1350 for tests to pass.

@jishnub jishnub force-pushed the jishnub/unit_tri_scale branch from 838daac to a290d4d Compare May 12, 2025 10:41
@codecov
Copy link

codecov bot commented May 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.74%. Comparing base (3393398) to head (a290d4d).
Report is 11 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1351   +/-   ##
=======================================
  Coverage   93.74%   93.74%           
=======================================
  Files          34       34           
  Lines       15752    15747    -5     
=======================================
- Hits        14766    14762    -4     
+ Misses        986      985    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jishnub jishnub merged commit c723c59 into master May 22, 2025
4 checks passed
@jishnub jishnub deleted the jishnub/unit_tri_scale branch May 22, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant