Make adjoint/transpose for Diagonal/Bidiagonal lazy
#1368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1368 +/- ##
==========================================
- Coverage 93.83% 93.81% -0.03%
==========================================
Files 34 34
Lines 15708 15709 +1
==========================================
- Hits 14740 14737 -3
- Misses 968 972 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dkarrasch
reviewed
Jun 1, 2025
Member
dkarrasch
left a comment
dkarrasch
left a comment
There was a problem hiding this comment.
Maybe help it simplify a little bit in the real case?
dkarrasch
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
adjointandtransposefor a blockDiagonaland a blockBidiagonalmatrix allocates the diagonals. This was not intentional, and we may use lazy wrappers instead that ensures that the result shares memory with the original array, which is what the documentation states. After this PR, mutating theadjointwill automatically mutate the parent array.