Skip to content

Forward diagview for adjoint/transpose to parent #1373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2025
Merged

Forward diagview for adjoint/transpose to parent #1373

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68c6968
Forward `diagview` for `adjoint`/`transpose` to parent
jishnub Jun 2, 2025
1ab987c
Check `diagview` against `diag` instead of copying
jishnub Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/adjtrans.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,3 +569,6 @@ Compute `vec(adjoint(A))`, but avoid an allocating reshape if possible
"""
_vecadjoint(A::AbstractVector) = vec(adjoint(A))
_vecadjoint(A::Base.ReshapedArray{<:Any,1,<:AdjointAbsVec}) = adjoint(parent(A))

diagview(A::Transpose, k::Integer = 0) = _vectranspose(diagview(parent(A), -k))
diagview(A::Adjoint, k::Integer = 0) = _vecadjoint(diagview(parent(A), -k))
11 changes: 11 additions & 0 deletions test/adjtrans.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -788,4 +788,15 @@ end
end
end

@testset "diagview" begin
for A in (rand(4, 4), rand(ComplexF64,4,4),
fill([1 2; 3 4], 4, 4))
for k in -3:3
@test diagview(A', k) == diagview(copy(A'), k)
@test diagview(transpose(A), k) == diagview(copy(transpose(A)), k)
end
@test IndexStyle(diagview(A')) == IndexLinear()
end
end

end # module TestAdjointTranspose