Skip to content

Avoid explicit one-based indexing in structured broadcast copyto! methods #1375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025
Merged

Avoid explicit one-based indexing in structured broadcast copyto! methods #1375

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/structuredbroadcast.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ function copyto!(dest::Diagonal, bc::Broadcasted{<:StructuredMatrixStyle})
isvalidstructbc(dest, bc) || return copyto!(dest, convert(Broadcasted{Nothing}, bc))
axs = axes(dest)
axes(bc) == axs || Broadcast.throwdm(axes(bc), axs)
for i in axs[1]
for i in eachindex(dest.diag)
dest.diag[i] = @inbounds bc[BandIndex(0, i)]
end
return dest
Expand All @@ -222,15 +222,15 @@ function copyto!(dest::Bidiagonal, bc::Broadcasted{<:StructuredMatrixStyle})
isvalidstructbc(dest, bc) || return copyto!(dest, convert(Broadcasted{Nothing}, bc))
axs = axes(dest)
axes(bc) == axs || Broadcast.throwdm(axes(bc), axs)
for i in axs[1]
for i in eachindex(dest.dv)
dest.dv[i] = @inbounds bc[BandIndex(0, i)]
end
if dest.uplo == 'U'
for i = 1:size(dest, 1)-1
for i in eachindex(dest.ev)
dest.ev[i] = @inbounds bc[BandIndex(1, i)]
end
else
for i = 1:size(dest, 1)-1
for i in eachindex(dest.ev)
dest.ev[i] = @inbounds bc[BandIndex(-1, i)]
end
end
Expand All @@ -257,13 +257,13 @@ function copyto!(dest::Tridiagonal, bc::Broadcasted{<:StructuredMatrixStyle})
isvalidstructbc(dest, bc) || return copyto!(dest, convert(Broadcasted{Nothing}, bc))
axs = axes(dest)
axes(bc) == axs || Broadcast.throwdm(axes(bc), axs)
for i in axs[1]
for i in eachindex(dest.d)
dest.d[i] = @inbounds bc[BandIndex(0, i)]
end
for i = 1:size(dest, 1)-1
for i in eachindex(dest.du)
dest.du[i] = @inbounds bc[BandIndex(1, i)]
end
for i = 1:size(dest, 1)-1
for i in eachindex(dest.dl)
dest.dl[i] = @inbounds bc[BandIndex(-1, i)]
end
return dest
Expand Down