Skip to content

Generic fallback for fillstored! #1389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 1, 2025
Merged

Generic fallback for fillstored! #1389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e1f0571
Generic fallback for `fillstored!`
jishnub Jun 20, 2025
129e29f
Test wrappers explicitly
jishnub Jun 20, 2025
04503d4
Merge branch 'master' into jishnub/filstored_adjtrans
ViralBShah Aug 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/adjtrans.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,6 +582,11 @@ diagview(A::Adjoint, k::Integer = 0) = _vecadjoint(diagview(parent(A), -k))
triu!(A::AdjOrTransAbsMat, k::Integer = 0) = wrapperop(A)(tril!(parent(A), -k))
tril!(A::AdjOrTransAbsMat, k::Integer = 0) = wrapperop(A)(triu!(parent(A), -k))

function fillstored!(A::AdjOrTransAbsMat, v)
fillstored!(parent(A), wrapperop(A)(v))
return A
end

function fillband!(A::AdjOrTrans, v, k1, k2)
fillband!(parent(A), wrapperop(A)(v), -k2, -k1)
return A
Expand Down
2 changes: 2 additions & 0 deletions src/dense.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,8 @@ function fillband!(A::AbstractMatrix{T}, x, l, u) where T
return A
end

fillstored!(A::AbstractMatrix, v) = fill!(A, v)

diagind(m::Integer, n::Integer, k::Integer=0) = diagind(IndexLinear(), m, n, k)
diagind(::IndexLinear, m::Integer, n::Integer, k::Integer=0) =
k <= 0 ? range(1-k, step=m+1, length=min(m+k, n)) : range(k*m+1, step=m+1, length=min(m, n-k))
Expand Down
11 changes: 11 additions & 0 deletions test/adjtrans.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -810,6 +810,17 @@ end
end
end

@testset "fillstored!" begin
A = rand(ComplexF64, 4, 4)
U = UpperTriangular(A)
@testset for (op, f) in ((Adjoint, adjoint), (Transpose, transpose))
@test LinearAlgebra.fillstored!(op(A), 1) == op(fill(1, size(A)))
@test LinearAlgebra.fillstored!(op(A), 2im) == op(fill(f(2im), size(A)))
@test LinearAlgebra.fillstored!(op(U), 1) == op(triu(fill(1, size(U))))
@test LinearAlgebra.fillstored!(op(U), 2im) == op(triu(fill(f(2im), size(U))))
end
end

@testset "lmul!/rmul! by numbers" begin
@testset "$(eltype(A))" for A in (rand(4, 4), rand(ComplexF64,4,4),
fill([1 2; 3 4], 4, 4),
Expand Down