Skip to content

specialize kron!(::Diagonal, ::Diagonal, ::Diagonal) #1392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 1, 2025
Merged

specialize kron!(::Diagonal, ::Diagonal, ::Diagonal) #1392

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
063ee3d
specialize kron!(::Diagonal, ::Diagonal, ::Diagonal)
tam724 Jun 27, 2025
5c2d962
extend "kron! for Diagonal" testset
tam724 Jun 27, 2025
57ebfb4
add whitespaces
tam724 Jun 30, 2025
63339e9
Update test/diagonal.jl
dkarrasch Jun 30, 2025
2ffcafa
Merge branch 'master' into kron!_diagonal
tam724 Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/diagonal.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -806,6 +806,11 @@ end

kron(A::Diagonal, B::Diagonal) = Diagonal(kron(A.diag, B.diag))

function kron!(C::Diagonal, A::Diagonal, B::Diagonal)
kron!(C.diag, A.diag, B.diag)
return C
end

function kron(A::Diagonal, B::SymTridiagonal)
kdv = kron(A.diag, B.dv)
# We don't need to drop the last element
Expand Down
19 changes: 15 additions & 4 deletions test/diagonal.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1396,14 +1396,25 @@ end
end

@testset "kron! for Diagonal" begin
a = Diagonal([2,2])
b = Diagonal([1,1])
a = Diagonal([1,2])
b = Diagonal([3,4])
# Diagonal out
c = Diagonal([0,0,0,0])
kron!(c,b,a)
@test c == Diagonal([2,2,2,2])
@test c == Diagonal([3, 6, 4, 8])
@test c == kron!(fill(0, 4, 4), Matrix(b), Matrix(a)) # against dense kron!
c=Diagonal(Vector{Float64}(undef, 4))
kron!(c,a,b)
@test c == Diagonal([2,2,2,2])
@test c == Diagonal([3.0, 4.0, 6.0, 8.0])

# AbstractArray out
c = fill(0, 4, 4)
kron!(c, b, a)
@test c == diagm([3, 6, 4, 8])
@test c == kron!(fill(0, 4, 4), Matrix(b), Matrix(a)) # against dense kron!
c = Matrix{Float64}(undef, 4, 4)
kron!(c, a, b)
@test c == diagm([3.0, 4.0, 6.0, 8.0])
end

@testset "uppertriangular/lowertriangular" begin
Expand Down