[1.12] Run __init__() even in sysimage builds
#1408
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes the LinearAlgebra initialization code run during the sysimage build, similar to how it would run when using LinearAlgebra at top-level in a normal package. In this configuration, we can't rely on the serializer to isolate side-effects for us, so we have to manually ensure that any mutations that we perform here are not accidentally persisted to run-time. Accordingly, the `OncePerProcess` is here as a reminder that any code in this init have to think about phasing (and be careful not to leave behind changes from compile-time that would badly impact run-time).
topolarity
force-pushed
the
ct/init-once-per-process-1.12
branch
from
a8140cd to
4ec5faa
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.12 #1408 +/- ##
================================================
+ Coverage 93.56% 93.57% +0.01%
================================================
Files 34 34
Lines 15442 15444 +2
================================================
+ Hits 14448 14452 +4
+ Misses 994 992 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Closing in preference of #1407 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.12-specific version of #1407 (1.12 does not have LazyLibrary)
This change makes the LinearAlgebra initialization code run during the sysimage build, similar to how it would run when using LinearAlgebra at top-level in a normal package.
In this configuration, we can't rely on the serializer to isolate side-effects for us, so we have to manually ensure that any mutations that we perform here are not accidentally persisted to run-time. Accordingly, the
OncePerProcessis here as a reminder that any code in this init has to think about phasing.Requires JuliaLang/julia#59232
Resolves the segfault in JuliaLang/julia#59215