- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 35
Add bidiagonal cholesky version #1409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@           Coverage Diff           @@
##           master    #1409   +/-   ##
=======================================
  Coverage   93.86%   93.87%           
=======================================
  Files          34       34           
  Lines       15830    15852   +22     
=======================================
+ Hits        14859    14881   +22     
  Misses        971      971           ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
 | 
| Getting the generic version is even better than just calling  | 
| Thanks for your review. That was helpful! 
 I'll need to benchmark that. | 
bef9dfd    to
    bf09d41      
    Compare
  
    | So, to give an update: I replaced the LAPACK-call to the ldlt-routine by the Julia code that we use in the ldlt-module. Apparently, we don't reach out to LAPACK for that either, even though  | 
| It would be possible to edit the  | 
This adds a generic version of cholesky for tridiagonal matrices. This fixes #1383, and massively boosts performance both for
(Sym)Tridiagonals. Previously, we haven't had a kernel for the symtridiagonal case.