Backports release 1.12 #1411
Backports release 1.12 #1411
Conversation
With the release of Julia 1.12, LinearAlgebra.jl is adding dispatches for rank to SVD and QRPivoted objects, allowing the re-use of existing matrix factorizations where they have already been computed. The SVD method already has an appropriate docstring; this PR adds a near-identical one to the QRPivoted method as well, with some additional context for how it differs from the default SVD-based computation.
dkarrasch
force-pushed
the
backports-release-1.12
branch
from
a53d7d4 to
9941132
Compare
Co-authored-by: Viral B. Shah <[email protected]> Co-authored-by: Jishnu Bhattacharya <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-1.12 #1411 +/- ##
================================================
+ Coverage 93.17% 93.55% +0.37%
================================================
Files 34 34
Lines 15883 15452 -431
================================================
- Hits 14799 14456 -343
+ Misses 1084 996 -88 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@dkarrasch @jishnub I marked a few PRs for backporting to 1.12 and one for backport to LTS. I have been a bit aggressive about these. Could you take a look and see if you agree? If not, do feel free to remove the label. I am thinking we should get the backports onto the julia repo (whichever ones we want) by end of the week. |
After this,
```julia
julia> B = reshape([1:9;], 3, 3)
3×3 Matrix{Int64}:
1 4 7
2 5 8
3 6 9
julia> diagview(B', 1)
2-element view(::Vector{Int64}, 2:4:6) with eltype Int64:
2
6
```
The view directly indexes into the parent, and the `adjoint` layer is
removed. This also makes the view linearly indexed.
We may forward the operation to the parent, which would usually ensure that the loops are cache-friendly.
|
The Seems like should be a straightforward fix since it is missing some type parameter. Perhaps there is some dependency on other changes on master? |
|
Yes, I messed up the merge. |
|
Looks good to merge. |
|
Now I'm done. I'll try to squash the svd-related commits together, and merge myself later. |
dkarrasch
force-pushed
the
backports-release-1.12
branch
from
49f91e2 to
bd88dc9
Compare
|
Whoever is first (in case I get distracted), this is ready to merge after CI is green. |
…1418) Fixes #1415 --------- Co-authored-by: Steven G. Johnson <[email protected]>
dkarrasch
force-pushed
the
backports-release-1.12
branch
from
bd88dc9 to
fb7bee4
Compare
|
@dkarrasch There's a bunch of other files on I changed the CI for all the release and backport branches to mirror the Julia version they are meant for to be more accurate. Unfortunately I believe I have changed the |
7 participants
[x] #1365
[x] #1373
[x] #1385
[x] #1397
[x] #1402
[x] #1413
[x] #1417
[x] #1418