Skip to content

Conversation

@dkarrasch
Copy link
Member

@dkarrasch dkarrasch commented Aug 11, 2025

The type alias included SymTridiagonal, which doesn't make sense here, (edit: and wasn't working anyways). This has not been released.

@dkarrasch dkarrasch added the backport 1.12 Change should be backported to release-1.12 label Aug 11, 2025
@codecov
Copy link

codecov bot commented Aug 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.86%. Comparing base (1ffbf9d) to head (a4ca570).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1412      +/-   ##
==========================================
- Coverage   93.89%   93.86%   -0.04%     
==========================================
  Files          34       34              
  Lines       15830    15830              
==========================================
- Hits        14864    14859       -5     
- Misses        966      971       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dkarrasch dkarrasch merged commit 16f64e7 into master Aug 11, 2025
3 of 4 checks passed
@dkarrasch dkarrasch deleted the dk/fix-chol-signature branch August 11, 2025 11:01
dkarrasch added a commit that referenced this pull request Aug 11, 2025
@dkarrasch dkarrasch removed the backport 1.12 Change should be backported to release-1.12 label Aug 11, 2025
@ViralBShah ViralBShah added the backport 1.12 Change should be backported to release-1.12 label Aug 13, 2025
@dkarrasch dkarrasch removed the backport 1.12 Change should be backported to release-1.12 label Aug 21, 2025
@dkarrasch
Copy link
Member Author

Doesn't need backporting. The addition of SymTridiagonal to const SelfAdjoint hasn't been done on the release-v1.12 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants