Skip to content

Conversation

@dkarrasch
Copy link
Member

Fixes #1414.

@codecov
Copy link

codecov bot commented Aug 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.87%. Comparing base (7e647cf) to head (5ed0514).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1416   +/-   ##
=======================================
  Coverage   93.87%   93.87%           
=======================================
  Files          34       34           
  Lines       15851    15851           
=======================================
  Hits        14880    14880           
  Misses        971      971           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dkarrasch
Copy link
Member Author

I think my previous tests were actually flawed. They pass on many examples, but not systematically. You can't trick math. 😅

@dkarrasch dkarrasch merged commit 6c92d28 into master Aug 14, 2025
4 checks passed
@dkarrasch dkarrasch deleted the dk/fix-chol-test branch August 14, 2025 12:17
@ViralBShah
Copy link
Member

Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some cholesky tests are failing because the matrix is not positive definite

2 participants