test: relax @test_throws ErrorException to also allow BoundsError
#1431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An issue with `Base` is that some methods of `size` throw `BoundsError` for an out-of-bounds second argument, while others throw `ErrorException` in the same case. Relax the tests here to allow for fixing that issue in `Base` in the future. PR that depends on this change: * JuliaLang/julia#59442
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1431 +/- ##
=======================================
Coverage 93.89% 93.89%
=======================================
Files 34 34
Lines 15896 15896
=======================================
Hits 14925 14925
Misses 971 971 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nsajko
added a commit
to nsajko/julia
that referenced
this pull request
Sep 2, 2025
Specifically I want this because of PR JuliaLang/LinearAlgebra.jl#1431, which PR JuliaLang#59442 depends on.
nsajko
added a commit
to nsajko/julia
that referenced
this pull request
Sep 2, 2025
Specifically I want this because of PR JuliaLang/LinearAlgebra.jl#1431, which PR JuliaLang#59442 depends on.
nsajko
added a commit
to nsajko/julia
that referenced
this pull request
Sep 3, 2025
Specifically I want this because of PR JuliaLang/LinearAlgebra.jl#1431, which PR JuliaLang#59442 depends on. (cherry picked from commit 54f21dd3217e6c481eb37d82a9506f76c6d8c92c)
nsajko
added a commit
to nsajko/julia
that referenced
this pull request
Sep 3, 2025
Specifically I want this because of PR JuliaLang/LinearAlgebra.jl#1431, which PR JuliaLang#59442 depends on. (cherry picked from PR JuliaLang#59464)
ViralBShah
pushed a commit
to JuliaLang/julia
that referenced
this pull request
Sep 3, 2025
Specifically I want this because of PR JuliaLang/LinearAlgebra.jl#1431, which PR #59442 depends on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue with
Baseis that some methods ofsizethrowBoundsErrorfor an out-of-bounds second argument, while others throwErrorExceptionin the same case.Relax the tests here to allow for fixing that issue in
Basein the future.PR that depends on this change:
lengthandsizejulia#59442