Skip to content

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Sep 11, 2025

This lets one access the uplo field of a Symmetric/Hermitian matrix without accessing the internal fields of the struct.

Copy link

codecov bot commented Sep 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.89%. Comparing base (98723df) to head (456d440).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1440   +/-   ##
=======================================
  Coverage   93.89%   93.89%           
=======================================
  Files          34       34           
  Lines       15920    15922    +2     
=======================================
+ Hits        14948    14950    +2     
  Misses        972      972           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@araujoms
Copy link
Collaborator

Any particular reason why you're returning a Symbol instead of a Char?

@jishnub
Copy link
Member Author

jishnub commented Sep 11, 2025

Mainly because this matches what the constructor accepts. I'm ok with either choice.

@mikmoore
Copy link
Contributor

Maybe add Bidiagonal to the list. Any others?

Copy link
Contributor

@tpapp tpapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarify what the symbols can be.

Copy link
Contributor

@tpapp tpapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@stevengj
Copy link
Member

The new docstring should be added to https://github.com/JuliaLang/LinearAlgebra.jl/blob/master/docs/src/index.md (and potentially linked from elsewhere in the doc)? Maybe should also be linked from the docstrings for Symmetric etc?

@jishnub jishnub merged commit 8d6ca14 into master Sep 20, 2025
4 checks passed
@jishnub jishnub deleted the jishnub/sym_uplo branch September 20, 2025 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants