-
-
Notifications
You must be signed in to change notification settings - Fork 34
Public function to access the uplo
for Symmetric
/Hermitian
#1440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1440 +/- ##
=======================================
Coverage 93.89% 93.89%
=======================================
Files 34 34
Lines 15920 15922 +2
=======================================
+ Hits 14948 14950 +2
Misses 972 972 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Any particular reason why you're returning a |
Mainly because this matches what the constructor accepts. I'm ok with either choice. |
Maybe add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarify what the symbols can be.
Co-authored-by: Tamas K. Papp <[email protected]>
Co-authored-by: Tamas K. Papp <[email protected]>
This reverts commit 342fc63.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
The new docstring should be added to https://github.com/JuliaLang/LinearAlgebra.jl/blob/master/docs/src/index.md (and potentially linked from elsewhere in the doc)? Maybe should also be linked from the docstrings for |
This lets one access the
uplo
field of aSymmetric
/Hermitian
matrix without accessing the internal fields of the struct.