Skip to content

Conversation

@dkarrasch
Copy link
Member

Fixes #1291.

@codecov
Copy link

codecov bot commented Nov 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.92%. Comparing base (189d49d) to head (8f27f1f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1499      +/-   ##
==========================================
- Coverage   93.93%   93.92%   -0.01%     
==========================================
  Files          34       34              
  Lines       15982    15983       +1     
==========================================
  Hits        15012    15012              
- Misses        970      971       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dkarrasch dkarrasch requested a review from mcabbott December 4, 2025 08:54
end
end
iszero(alpha) && return C
(iszero(alpha) || isempty(A) || isempty(B)) && return C
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why this is related. Appears safe, given that we've already dealt with beta!=0 above.

But I'm confused about the case of nonzero beta and non-empty A,B in code just above. It seems that this code does C .*= beta, but then ignores A, B? Maybe I'm missing something. Not new to this PR. Haven't looked at tests for this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, in that part it does C .*= beta. If iszero(alpha), then this is all that needs to be done in

C = A*B*alpha + C*beta

This change is unrelated, it just avoids "running empty loops" in the sequel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong eltype in 3-arg *

2 participants