Skip another test (the create_library() test) on Julia 1.12 (because it does incremental=false)

Author: DilumAluthge

test/runtests.jl

@@ -88,9 +88,11 @@ end
     @testset for incremental in (is_slow_ci ? (false,) : (true, false))
         if incremental == false
             if is_julia_1_11 || is_julia_1_12
-                # On Julia 1.11 and 1.12, `incremental=false` is currently broken: https://github.com/JuliaLang/PackageCompiler.jl/issues/976
+                # On Julia 1.11 and 1.12, `incremental=false` is currently broken.
+                # 1.11: https://github.com/JuliaLang/PackageCompiler.jl/issues/976
+                # 1.12: No GitHub issue yet.
                 # So, for now, we skip the `incremental=false` tests on Julia 1.11 and 1.12
-                @warn "This is Julia $(VERSION.major).$(VERSION.minor); skipping incremental=false test due to known bug: https://github.com/JuliaLang/PackageCompiler.jl/issues/976"
+                @warn "This is Julia $(VERSION.major).$(VERSION.minor); skipping incremental=false test due to known bug: #976 (for 1.11), issue TODO (for 1.12)"
                 @test_skip false
                 continue
             end
@@ -194,21 +196,32 @@ end
     end # testset
 
     if !is_slow_ci
-        # Test library creation
-        lib_source_dir = joinpath(@__DIR__, "..", "examples/MyLib")
-        lib_target_dir = joinpath(tmp, "MyLibCompiled")
-
-        incremental = false
-        filter = true
-        lib_name = "inc"
-
-        tmp_lib_src_dir = joinpath(tmp, "MyLib")
-        cp(lib_source_dir, tmp_lib_src_dir)
-        create_library(tmp_lib_src_dir, lib_target_dir; incremental=incremental, force=true, filter_stdlibs=filter,
-                    precompile_execution_file=joinpath(lib_source_dir, "build", "generate_precompile.jl"),
-                    precompile_statements_file=joinpath(lib_source_dir, "build", "additional_precompile.jl"),
-                    lib_name=lib_name, version=v"1.0.0")
-        rm(tmp_lib_src_dir; recursive=true)
+        if is_julia_1_12
+        # On Julia 1.12, `incremental=false` is currently broken when doing `create_library()`.
+        # 1.12: No GitHub issue yet.
+        # So, for now, we skip the `incremental=false` tests on Julia 1.12 when doing `create_library()`.
+            @warn "This is Julia $(VERSION.major).$(VERSION.minor); skipping incremental=false test when doing `create_library()` due to known bug: issue TODO (for 1.12)"
+                @test_skip false
+                continue
+        else
+            # Test library creation
+            lib_source_dir = joinpath(@__DIR__, "..", "examples/MyLib")
+            lib_target_dir = joinpath(tmp, "MyLibCompiled")
+
+            # This is why we have to skip this test on 1.12:
+            incremental = false
+            
+            filter = true
+            lib_name = "inc"
+
+            tmp_lib_src_dir = joinpath(tmp, "MyLib")
+            cp(lib_source_dir, tmp_lib_src_dir)
+            create_library(tmp_lib_src_dir, lib_target_dir; incremental=incremental, force=true, filter_stdlibs=filter,
+                        precompile_execution_file=joinpath(lib_source_dir, "build", "generate_precompile.jl"),
+                        precompile_statements_file=joinpath(lib_source_dir, "build", "additional_precompile.jl"),
+                        lib_name=lib_name, version=v"1.0.0")
+            rm(tmp_lib_src_dir; recursive=true)
+        end
     end
 
     # Test creating an empty sysimage