Skip to content

CI: Test both incremental={true,false} on "slow CI"; also, stop considering Apple Silicon macOS as "slow CI" #983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DilumAluthge merged 10 commits into from
Oct 20, 2024
Merged

CI: Test both incremental={true,false} on "slow CI"; also, stop considering Apple Silicon macOS as "slow CI" #983

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
23f78a1
CI: Run a single job on Julia nightly
DilumAluthge Oct 20, 2024
63d18fd
More contents
DilumAluthge Oct 20, 2024
c266c32
More contents
DilumAluthge Oct 20, 2024
1ffd504
Fix typo
DilumAluthge Oct 20, 2024
0ede753
Skip the `incremental=false` tests on Julia nightly
DilumAluthge Oct 20, 2024
0091cfe
Skip another test (the `create_library()` test) on Julia 1.12 (becaus…
DilumAluthge Oct 20, 2024
5748b54
Fix
DilumAluthge Oct 20, 2024
c2b1247
CI: Test both `incremental={true,false}` on "slow CI"
DilumAluthge Oct 20, 2024
ddcd9e3
Don't count Apple Silicon macOS as "slow CI"
DilumAluthge Oct 20, 2024
14f260e
Merge branch 'master' into dpa/slow-ci
DilumAluthge Oct 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,16 @@ ENV["JULIA_DEPOT_PATH"] = new_depot
Base.init_depot_path()

const is_ci = tryparse(Bool, get(ENV, "CI", "")) === true
const is_slow_ci = is_ci && Sys.ARCH == :aarch64
const is_apple_silicon_macos = Sys.ARCH == :aarch64 && Sys.isapple()

# In order to be "slow CI", we must meet all of the following:
# 1. We are running on CI.
# 2. We are running on aarch64 (arm64).
# 3. We are NOT running on Apple Silicon macOS.
# (Because for GitHub Actions, the GitHub-hosted Apple Silicon
# macOS runners seem to be quite fast.)
const is_slow_ci = is_ci && Sys.ARCH == :aarch64 && !is_apple_silicon_macos

const is_julia_1_6 = VERSION.major == 1 && VERSION.minor == 6
const is_julia_1_9 = VERSION.major == 1 && VERSION.minor == 9
const is_julia_1_11 = VERSION.major == 1 && VERSION.minor == 11
Expand Down Expand Up @@ -85,7 +94,12 @@ end
# Test creating an app
app_source_dir = joinpath(@__DIR__, "..", "examples/MyApp/")
app_compiled_dir = joinpath(tmp, "MyAppCompiled")
@testset for incremental in (is_slow_ci ? (false,) : (true, false))
if is_slow_ci
incrementals_list = (true, false)
else
incrementals_list = (true, false)
end
@testset for incremental in incrementals_list
if incremental == false
if is_julia_1_11 || is_julia_1_12
# On Julia 1.11 and 1.12, `incremental=false` is currently broken.
Expand All @@ -96,7 +110,11 @@ end
@test_skip false
continue
end
filter_stdlibs = (is_slow_ci ? (true, ) : (true, false))
if is_slow_ci
filter_stdlibs = (true,)
else
filter_stdlibs = (true, false)
end
else
filter_stdlibs = (false,)
end
Expand Down
Loading