Skip to content

Remove test that depends on Random being in the sysimg #3656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Remove test that depends on Random being in the sysimg #3656

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion test/api.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,6 @@ import .FakeTerminals.FakeTerminal
@test_throws Pkg.Types.PkgError Pkg.precompile("DoesNotExist") # fail to find a nonexistant dep in an empty env

Pkg.add("Random")
@test_throws Pkg.Types.PkgError Pkg.precompile("Random") # Random is a dep but in the sysimage
Copy link
Member

@IanButterworth IanButterworth Oct 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace with something in the sysimage? Also the add above needs changing

Copy link
Member Author

@vchuravy vchuravy Oct 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is that if all my plans are going to work there will be nothing in the sysimg.

The add there still is useful since it tests that adding a stdlib works.

Looks at Ian meaningful and points at FileWatching

Copy link
Member

@IanButterworth IanButterworth Oct 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahem.. JuliaLang/julia#51463 (comment)

True, but Pkg still needs to serve people that make sysimages with modules in them.
Building a whole other sysimage would be too much, so perhaps this just has to be untested then..

Copy link
Member Author

@vchuravy vchuravy Oct 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need an "EmptyStdlib" to make sure that the loading infrastructure is properly precompiled.

@test_throws Pkg.Types.PkgError Pkg.precompile("DoesNotExist")
Pkg.precompile() # should be a no-op
end end
Expand Down