Add --dry-run for add/update etc.#4411
Open
IanButterworth wants to merge 1 commit intoJuliaLang:masterfrom
Open
Add --dry-run for add/update etc.#4411IanButterworth wants to merge 1 commit intoJuliaLang:masterfrom
--dry-run for add/update etc.#4411IanButterworth wants to merge 1 commit intoJuliaLang:masterfrom
Conversation
Member
Author
|
This needs a bit more thought because undo states are only set if something changes, so it could currently undo too far back. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We previously had
previewmode, which was removed and replaced with a more robustundo/redo, but I think there's still benefit of having something likepreviewbut instead utilize the improvedundomechanics automatically at the end of the operation.i.e. if
undois robust, then this should be.I also thought
--dry-runwas more typical, given that's what cargo has.