Fix VersionSpec to VersionNumber conversion error when freeing packages #4555
+10
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes JuliaLang#4554 When freeing a dev'd or pinned package, `pkg.version` could remain as a `VersionSpec` in certain code paths, but `PackageEntry` requires `version::Union{VersionNumber, Nothing}`. This caused a MethodError when trying to convert VersionSpec to VersionNumber. The issue occurred because: 1. When freeing a package from dev/path/repo state, the version might not be updated through the normal resolve process 2. In some cases (e.g., pinned stdlibs), `update_package_free!` returns early without setting the version 3. The `PackageEntry` constructor was called with `pkg.version` which could be a `VersionSpec`, causing a type conversion error This fix adds defensive type checking before creating `PackageEntry` objects, converting non-VersionNumber values to `nothing`. The correct version will be set later if needed (e.g., for stdlibs). Changes: - src/Operations.jl: Added type check in update_manifest! - src/Apps/Apps.jl: Added type checks in two PackageEntry creations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4554
🤖 Written by Claude:
When freeing a dev'd or pinned package,
pkg.versioncould remain as aVersionSpecin certain code paths, butPackageEntryrequiresversion::Union{VersionNumber, Nothing}. This caused a MethodError when trying to convert VersionSpec to VersionNumber.The issue occurred because:
update_package_free!returns early without setting the versionPackageEntryconstructor was called withpkg.versionwhich could be aVersionSpec, causing a type conversion errorThis fix adds defensive type checking before creating
PackageEntryobjects, converting non-VersionNumber values tonothing. The correct version will be set later if needed (e.g., for stdlibs).