use function syntax, don't define method bodies explicitly

Author: nsajko

test/no_invalidations.jl

@@ -56,13 +56,13 @@ end
         @testset "construction of old int type from new type" begin
             broken = (Int8, UInt8, UInt16, Int, UInt)
             @testset "T: $T" for T ∈ int_types
-                @test test_expr((n -> :(Base.$T(::$n) = $T(0))), Integer) broken=(T ∈ broken)
+                @test test_expr((n -> :(function Base.$T(::$n) end)), Integer) broken=(T ∈ broken)
             end
         end
         @testset "construction of new int type from old type" begin
             broken = ()
             @testset "T: $T" for T ∈ int_types
-                @test test_expr((n -> :($n(::$T) = $n())), Integer) broken=(T ∈ broken)
+                @test test_expr((n -> :(function $n(::$T) end)), Integer) broken=(T ∈ broken)
             end
         end
         @testset "arithmetic between old int types and new int type" begin
@@ -71,8 +71,8 @@ end
             @testset "T: $T" for T ∈ int_types
                 @testset "op: $op" for op ∈ ops
                     @test (
-                        test_expr((n -> :(Base.$op(::$n, m::$T) = m)), Integer) &&
-                        test_expr((n -> :(Base.$op(m::$T, ::$n) = m)), Integer)
+                        test_expr((n -> :(function Base.$op(::$n, ::$T) end)), Integer) &&
+                        test_expr((n -> :(function Base.$op(::$T, ::$n) end)), Integer)
                     ) broken=((T, op) ∈ broken)
                 end
             end
@@ -81,14 +81,14 @@ end
             broken = (Bool, UInt8, Int)
             @testset "T: $T" for T ∈ int_types
                 @test (
-                    test_expr((n -> :(Base.promote_rule(::Type{$T}, ::Type{$n}) = $T)), Integer) &&
-                    test_expr((n -> :(Base.promote_rule(::Type{$n}, ::Type{$T}) = $T)), Integer)
+                    test_expr((n -> :(function Base.promote_rule(::Type{$T}, ::Type{$n}) end)), Integer) &&
+                    test_expr((n -> :(function Base.promote_rule(::Type{$n}, ::Type{$T}) end)), Integer)
                 ) broken=(T ∈ broken)
             end
         end
         @testset "unary functions" begin
-            @test test_expr((n -> :(Base.zero(::$n) = $n())), Integer) broken=true
-            @test test_expr((n -> :(Base.one(::$n) = $n())), Integer) broken=true
+            @test test_expr((n -> :(function Base.zero(::$n) end)), Integer) broken=true
+            @test test_expr((n -> :(function Base.one(::$n) end)), Integer) broken=true
         end
     end
 end