Skip to content

RFC: Improved (?) tab completion for symbols #26445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

RFC: Improved (?) tab completion for symbols #26445

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions stdlib/REPL/src/REPLCompletions.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,6 +422,21 @@ function afterusing(string::String, startpos::Int)
return contains(str[fr:end], r"^\b(using|import)\s*((\w+[.])*\w+\s*,\s*)*$")
end

function complete_symbols(comps, symbol_dict)
newcomps = []
for c in comps
smb = get(symbol_dict, c, c)
scomps, positions = completions(smb, 1)
(smb in scomps) || push!(newcomps, smb)
if !isempty(scomps)
for s in scomps
push!(newcomps, s)
end
end
end
return newcomps
end

function bslash_completions(string, pos)
slashpos = coalesce(findprev(equalto('\\'), string, pos), 0)
if (coalesce(findprev(occursin(bslash_separators), string, pos), 0) < slashpos &&
Expand All @@ -440,10 +455,12 @@ function bslash_completions(string, pos)
# Julian completions as only latex / emoji symbols contain the leading \
if startswith(s, "\\:") # emoji
emoji_names = Iterators.filter(k -> startswith(k, s), keys(emoji_symbols))
return (true, (sort!(collect(emoji_names)), slashpos:pos, true))
comps = complete_symbols(sort(collect(emoji_names)), emoji_symbols)
return (true, (comps, slashpos:pos, true))
else # latex
latex_names = Iterators.filter(k -> startswith(k, s), keys(latex_symbols))
return (true, (sort!(collect(latex_names)), slashpos:pos, true))
comps = complete_symbols(sort(collect(latex_names)), latex_symbols)
return (true, (comps, slashpos:pos, true))
end
end
return (false, (String[], 0:-1, false))
Expand Down