-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Structured opnorm #30138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Structured opnorm #30138
Changes from 2 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
71b1410
adding special opnorms for structured matrices
mcognetta b09b1b4
tridiag ignored the new methods
mcognetta e20742f
Merge branch 'master' into structured_opnorm
mcognetta e0fa431
testing
mcognetta dc2313e
Merge branch 'master' into structured_opnorm
mcognetta c497aaa
changing the opnorms for structured matrices to use mapreduce
mcognetta db56bd9
fix whitespace
mcognetta 9142ad4
fixing merge conflict
mcognetta bf04a2a
Merge branch 'master' into structured_opnorm
mcognetta cd966eb
combining all of the redundant methods and adding support for block d…
mcognetta 23a5c1a
Update diagonal.jl
mcognetta 0dbd827
Merge branch 'master' of https://github.com/JuliaLang/julia into stru…
mcognetta 548deda
Merge branch 'master' into structured_opnorm
mcognetta a14e917
Merge branch 'master' into structured_opnorm
mcognetta File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lower bidiagonal p=1 norm is the same code as upper bidiagonal p=Inf (and the same with upper p=1 and lower p=Inf). These can be combined but that would reduce readability in my opinion. Thoughts on how to make this cleaner?
One option is to do
_upnormInf(A::Bidiagonal) = _loopnorm1(A)and_lonormInf(A::Bidiagonal) = _upnorm1(A)and document it well.