Add Pidfile to FileWatching #44367
Merged
Add Pidfile to FileWatching #44367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Jameson Nash <[email protected]>
IanButterworth
force-pushed
the
ib/add_pidfile
branch
from
7fb4ca1 to
d5ea1bc
Compare
IanButterworth
force-pushed
the
ib/add_pidfile
branch
from
d5ea1bc to
9a81558
Compare
vtjnash
reviewed
Feb 28, 2022
Member
vtjnash
left a comment
vtjnash
left a comment
There was a problem hiding this comment.
LGTM, with minor suggested cleanup for VERSION checks
Co-authored-by: Jameson Nash <[email protected]>
DilumAluthge
removed
the
merge me
staticfloat
pushed a commit
to JuliaCI/julia-buildkite-testing
that referenced
this pull request
Mar 2, 2022
Co-authored-by: Jameson Nash <[email protected]> Co-authored-by: Jameson Nash <[email protected]>
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
Co-authored-by: Jameson Nash <[email protected]> Co-authored-by: Jameson Nash <[email protected]>
This was referenced May 9, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #42471 (a force push meant that couldn't be re-opened)
This bring's @vtjnash's https://github.com/vtjnash/Pidfile.jl into FileWatching
I did a very light touch port here. The only changes to the pidfile source were to fix imports/exports.
Closes #42571