Skip to content

Correction of lcm() for Array arguments #56113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
+8 −2
Closed

Correction of lcm() for Array arguments #56113

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c7cd31d
Correction of the gcd() and lcm() of Array
cyanescent Oct 11, 2024
0547eae
Merge pull request #1 from cyanescent/patch-Array-lcm-gcd
cyanescent Oct 11, 2024
4e82260
Simpler correction with better error
cyanescent Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions base/intfuncs.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ julia> gcd(1//3, 2)

julia> gcd(0, 0, 10, 15)
5

julia> gcd([1//3; 2//3])
1//3
```
"""
function gcd(a::T, b::T) where T<:Integer
Expand Down Expand Up @@ -125,6 +128,9 @@ julia> lcm(1//3, 2)

julia> lcm(1, 3, 5, 7)
105

julia> lcm([1//3; 2//3])
2//3
```
"""
function lcm(a::T, b::T) where T<:Integer
Expand All @@ -149,8 +155,8 @@ lcm(a::Real, b::Real, c::Real...) = lcm(a, lcm(b, c...))
gcd(a::T, b::T) where T<:Real = throw(MethodError(gcd, (a,b)))
lcm(a::T, b::T) where T<:Real = throw(MethodError(lcm, (a,b)))

gcd(abc::AbstractArray{<:Real}) = reduce(gcd, abc; init=zero(eltype(abc)))
lcm(abc::AbstractArray{<:Real}) = reduce(lcm, abc; init=one(eltype(abc)))
gcd(abc::AbstractArray{<:Real}) = reduce(gcd, abc; init=abc[1])
lcm(abc::AbstractArray{<:Real}) = reduce(lcm, abc; init=abc[1])

function gcd(abc::AbstractArray{<:Integer})
a = zero(eltype(abc))
Expand Down
Loading