Fixed opnorm #56500
Fixed opnorm #56500
Conversation
|
Is CI currently broken? The failures look unrelated to any changes here. |
|
I restarted the failed job - let's see if the retry passes. |
|
Hmmm. The failure persists after a retry. |
|
Keno suggests that this has been fixed on master, so perhaps we need to rebase this PR again? |
|
This has been addressed. You won't see any more PowerPC failures. |
|
@dgleich would you be able to rebase the branch? I tried but there are conflicts. |
|
Bump @dgleich ^ |
making a test case use `isapprox` instead of `==`.
dgleich
force-pushed
the
fixed-opnorm
branch
from
9eab7cc to
e9f8d12
Compare
|
Done. Thanks for the bump. Something went wrong with one of the automatic rebase steps, so I had to fix it with another commit. (But I imagine these get squashed when merged?) |
|
@dkarrasch I was about to review this but I'm formally the author of the PR although I didn't write a line of it so I'm not allowed to review. Would you be able to? |
|
@andreasnoack do you want me to send in a new pull request from my account for this one so you can do the review? |
|
@dgleich Indeed, you could actually prepare a new PR to the now outsourced https://github.com/JuliaLang/LinearAlgebra.jl. I'll try to find some time to make a review (though it's not technically necessary for merging). |
|
Moved to JuliaLang/LinearAlgebra.jl#1138 |
Originally written by mcognetta See JuliaLang/julia#56500 and JuliaLang/julia#30138
6 participants
A rebased version of #30138