Skip to content

[deps] Fix build systems of curl and openssl #56960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2025
Merged

[deps] Fix build systems of curl and openssl #56960

merged 1 commit into from
Jan 5, 2025

Conversation

@giordano
Copy link
Member

@giordano giordano commented Jan 5, 2025

@giordano
[deps] Fix build systems of curl and openssl
bd7d5d6 
* Curl was missing a dependency on OpenSSL after JuliaLang#56708
* openssl is missing configuration target for riscv64
@giordano giordano added building Build system, or building Julia or its dependencies external dependencies Involves LLVM, OpenBLAS, or other linked libraries system:riscv Support for Risc-V cpus labels Jan 5, 2025
giordano
giordano commented Jan 5, 2025
View reviewed changes
deps/openssl.mk
else ifeq ($(ARCH),powerpc64le)
OPENSSL_TARGET := linux-ppc64le
else ifeq ($(ARCH),riscv64)
OPENSSL_TARGET := linux64-riscv64
Copy link
Member Author

@giordano giordano Jan 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reference for this target name: https://github.com/openssl/openssl/blob/817a2b2b4955da0233fe7e6e4bd16c0255262b4f/Configurations/10-main.conf#L819. Or run ./Configure --help on a riscv64-linux box.

@giordano giordano merged commit 89afe20 into JuliaLang:master Jan 5, 2025
10 checks passed
@giordano giordano deleted the mg/deps-curl-openssl branch January 5, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

building Build system, or building Julia or its dependencies external dependencies Involves LLVM, OpenBLAS, or other linked libraries system:riscv Support for Risc-V cpus

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@giordano